P
P
PQ Reviews
Search…
0.7
Finished Reviews
Retired
Powered By GitBook
Qubit Finance Process Quality Review
Score: 43%

Overview

This is a Qubit Finance Process Quality Review completed on August 31st 2021. It was performed using the Process Review process (version 0.7.3) and is documented here. The review was performed by Nic of DeFiSafety. Check out our Telegram.
The final score of the review is 43%, a FAIL. The breakdown of the scoring is in Scoring Appendix. For our purposes, a pass is 70%.

Summary of the Process

Very simply, the review looks for the following declarations from the developer's site. With these declarations, it is reasonable to trust the smart contracts.
    Here are my smart contracts on the blockchain
    Here is the documentation that explains what my smart contracts do
    Here are the tests I ran to verify my smart contract
    Here are the audit(s) performed on my code by third party experts
    Here are the admin controls and strategies

Disclaimer

This report is for informational purposes only and does not constitute investment advice of any kind, nor does it constitute an offer to provide investment advisory or other services. Nothing in this report shall be considered a solicitation or offer to buy or sell any security, token, future, option or other financial instrument or to offer or provide any investment advice or service to any person in any jurisdiction. Nothing contained in this report constitutes investment advice or offers any opinion with respect to the suitability of any security, and the views expressed in this report should not be taken as advice to buy, sell or hold any security. The information in this report should not be relied upon for the purpose of investing. In preparing the information contained in this report, we have not taken into account the investment needs, objectives and financial circumstances of any particular investor. This information has no regard to the specific investment objectives, financial situation and particular needs of any specific recipient of this information and investments discussed may not be suitable for all investors.
Any views expressed in this report by us were prepared based upon the information available to us at the time such views were written. The views expressed within this report are limited to DeFiSafety and the author and do not reflect those of any additional or third party and are strictly based upon DeFiSafety, its authors, interpretations and evaluation of relevant data. Changed or additional information could cause such views to change. All information is subject to possible correction. Information may quickly become unreliable for various reasons, including changes in market conditions or economic circumstances.
This completed report is copyright (c) DeFiSafety 2021. Permission is given to copy in whole, retaining this copyright label.

Chain

This section indicates the blockchain used by this protocol.
Chain: Binance Smart Chain
Guidance: Ethereum Binance Smart Chain Polygon Avalanche Terra

Code and Team

This section looks at the code deployed on the Mainnet that gets reviewed and its corresponding software repository. The document explaining these questions is here. This review will answer the following questions:
1) Are the executing code addresses readily available? (%) 2) Is the code actively being used? (%) 3) Is there a public software repository? (Y/N) 4) Is there a development history visible? (%) 5) Is the team public (not anonymous)? (Y/N)

1) Are the executing code addresses readily available? (%)

Answer: 100%
They are available at website https://github.com/PancakeBunny-finance/qubit-finance, as indicated in the Appendix.
Guidance: 100% Clearly labelled and on website, docs or repo, quick to find 70% Clearly labelled and on website, docs or repo but takes a bit of looking 40% Addresses in mainnet.json, in discord or sub graph, etc 20% Address found but labeling not clear or easy to find 0% Executing addresses could not be found

2) Is the code actively being used? (%)

Answer: 100%
Activity is over 10 transactions a day on contract TransparentUpgradeableProxy.sol (Locker/Staking Contract), as indicated in the Appendix.

Guidance:

100% More than 10 transactions a day 70% More than 10 transactions a week 40% More than 10 transactions a month 10% Less than 10 transactions a month 0% No activity

3) Is there a public software repository? (Y/N)

Answer: Yes
Is there a public software repository with the code at a minimum, but also normally test and scripts. Even if the repository was created just to hold the files and has just 1 transaction, it gets a "Yes". For teams with private repositories, this answer is "No".

4) Is there a development history visible? (%)

Answer: 30%
With 30 commits and 1 branch, this is an underdeveloped software repository.
This metric checks if the software repository demonstrates a strong steady history. This is normally demonstrated by commits, branches and releases in a software repository. A healthy history demonstrates a history of more than a month (at a minimum).
Guidance: 100% Any one of 100+ commits, 10+branches 70% Any one of 70+ commits, 7+branches 50% Any one of 50+ commits, 5+branches 30% Any one of 30+ commits, 3+branches 0% Less than 2 branches or less than 30 commits

How to improve this score:

Continue to test and perform other verification activities after deployment, including routine maintenance updating to new releases of testing and deployment tools. A public development history indicates clearly to the public the level of continued investment and activity by the developers on the application. This gives a level of security and faith in the application.

5) Is the team public (not anonymous)? (Y/N)

Answer: No
For a "Yes" in this question, the real names of some team members must be public on the website or other documentation (LinkedIn, etc). If the team is anonymous, then this question is a "No".

Documentation

This section looks at the software documentation. The document explaining these questions is here.
Required questions are;
6) Is there a whitepaper? (Y/N) 7) Are the basic software functions documented? (Y/N) 8) Does the software function documentation fully (100%) cover the deployed contracts? (%) 9) Are there sufficiently detailed comments for all functions within the deployed contract code (%) 10) Is it possible to trace from software documentation to the implementation in code (%)

6) Is there a whitepaper? (Y/N)

Answer: Yes

7) Are the basic software functions documented? (Y/N)

Answer: No
There are software functions documented in any of the Qubit Finance documentation.

How to improve this score:

Write the document based on the deployed code. For guidance, refer to the SecurEth System Description Document.

8) Does the software function documentation fully (100%) cover the deployed contracts? (%)

Answer: 0%
There are software functions documented in any of the Qubit Finance documentation.
Guidance:
100% All contracts and functions documented 80% Only the major functions documented 79-1% Estimate of the level of software documentation 0% No software documentation

How to improve this score:

This score can be improved by adding content to the software functions document such that it comprehensively covers the requirements. For guidance, refer to the SecurEth System Description Document. Using tools that aid traceability detection will help.

9) Are there sufficiently detailed comments for all functions within the deployed contract code (%)

Answer: 0%
Code examples are in the Appendix. As per the SLOC, there is 33% commenting to code (CtC).
The Comments to Code (CtC) ratio is the primary metric for this score.
Note: Interface, library, and any third-party files were not used in the calculation of Qubit Finance's CtC. In addition, a majority of their comments include the copyright section at the beginning of them. If you remove that, they get under 20%, hence the 0% overall score for this section.
Guidance: 100% CtC > 100 Useful comments consistently on all code 90-70% CtC > 70 Useful comment on most code 60-20% CtC > 20 Some useful commenting 0% CtC < 20 No useful commenting

How to improve this score

This score can improve by adding comments to the deployed code such that it comprehensively covers the code. For guidance, refer to the SecurEth Software Requirements.

10) Is it possible to trace from software documentation to the implementation in code (%)

Answer: 0%
There are software functions documented in any of the Qubit Finance documentation. Therefore, there is also no traceability towards their implementation in the Qubit Finance source code.
Guidance: 100% Clear explicit traceability between code and documentation at a requirement level for all code 60% Clear association between code and documents via non explicit traceability 40% Documentation lists all the functions and describes their functions 0% No connection between documentation and code

How to improve this score:

This score can improve by adding traceability from documentation to code such that it is clear where each outlined function is coded in the source code. For reference, check the SecurEth guidelines on traceability.

Testing

This section looks at the software testing available. It is explained in this document. This section answers the following questions;
11) Full test suite (Covers all the deployed code) (%) 12) Code coverage (Covers all the deployed lines of code, or explains misses) (%) 13) Scripts and instructions to run the tests (Y/N) 14) Report of the results (%) 15) Formal Verification test done (%) 16) Stress Testing environment (%)

11) Is there a Full test suite? (%)

Answer: 0%
There is no testing suite in the Qubit Finance software repository.
Guidance: 100% TtC > 120% Both unit and system test visible 80% TtC > 80% Both unit and system test visible 40% TtC < 80% Some tests visible 0% No tests obvious

How to improve this score:

This score can improved by adding tests to fully cover the code. Document what is covered by traceability or test results in the software repository.

12) Code coverage (Covers all the deployed lines of code, or explains misses) (%)

Answer: 0%
There is no evidence of any Qubit Finance code coverage in any of their documentation or in their PeckShield audit report.
Guidance: 100% Documented full coverage 99-51% Value of test coverage from documented results 50% No indication of code coverage but clearly there is a reasonably complete set of tests 30% Some tests evident but not complete 0% No test for coverage seen

How to improve this score:

This score can improved by adding tests that achieve full code coverage. A clear report and scripts in the software repository will guarantee a high score.

13) Scripts and instructions to run the tests (Y/N)

Answer: No

How to improve this score:

Add the scripts to the repository and ensure they work. Ask an outsider to create the environment and run the tests. Improve the scripts and docs based on their feedback.

14) Report of the results (%)

Answer: 0%
No report of any kind was found in any of the Qubit Finance documentation.
Guidance: 100% Detailed test report as described below 70% GitHub code coverage report visible 0% No test report evident

How to improve this score

Add a report with the results. The test scripts should generate the report or elements of it.

15) Formal Verification test done (%)

Answer: 0%
No evidence of a Qubit Finance Formal Verification test was found in their documentation or in additional web research.

16) Stress Testing environment (%)

Answer: 100%
There is evidence of Qubit Finance's testnet smart contract usage in the README.md of their GitHub repository.

Security

This section looks at the 3rd party software audits done. It is explained in this document. This section answers the following questions;
17) Did 3rd Party audits take place? (%) 18) Is the bounty value acceptably high?

17) Did 3rd Party audits take place? (%)

Answer: 90%
PeckShield published a Qubit Finance audit report on August 13th 2021, which was after their mainnet launch that took place on July 19th 2021. However changes requested were fixed.
Note: Most fix recommendations were successfully implemented by the Qubit Finance team.
Guidance: 100% Multiple Audits performed before deployment and results public and implemented or not required 90% Single audit performed before deployment and results public and implemented or not required 70% Audit(s) performed after deployment and no changes required. Audit report is public
50% Audit(s) performed after deployment and changes needed but not implemented 20% No audit performed 0% Audit Performed after deployment, existence is public, report is not public and no improvements deployed OR smart contract address' not found, (where question 1 is 0%)
Deduct 25% if code is in a private repo and no note from auditors that audit is applicable to deployed code

18) Is the bounty value acceptably high (%)

Answer: 70%
The developers of Qubit Finance, Mound Finance, have a bug bounty program with Immunefi since July 20th 2021. It rewards participating users with up to 250k for the most critical of finds.
Guidance:
100% Bounty is 10% TVL or at least $1M AND active program (see below) 90% Bounty is 5% TVL or at least 500k AND active program 80% Bounty is 5% TVL or at least 500k 70% Bounty is 100k or over AND active program 60% Bounty is 100k or over 50% Bounty is 50k or over AND active program 40% Bounty is 50k or over 20% Bug bounty program bounty is less than 50k 0% No bug bounty program offered
An active program means that a third party (such as Immunefi) is actively driving hackers to the site. An inactive program would be static mentions on the docs.

Access Controls

This section covers the documentation of special access controls for a DeFi protocol. The admin access controls are the contracts that allow updating contracts or coefficients in the protocol. Since these contracts can allow the protocol admins to "change the rules", complete disclosure of capabilities is vital for user's transparency. It is explained in this document. The questions this section asks are as follow;
19) Can a user clearly and quickly find the status of the admin controls? 20) Is the information clear and complete? 21) Is the information in non-technical terms that pertain to the investments? 22) Is there Pause Control documentation including records of tests?

19) Can a user clearly and quickly find the status of the access controls (%)

Answer: 0%
There are currently no admin access controls documented in the Qubit Finance documentation. However, the addition of a Governance section is mentioned in their development roadmap.
Guidance: 100% Clearly labelled and on website, docs or repo, quick to find 70% Clearly labelled and on website, docs or repo but takes a bit of looking 40% Access control docs in multiple places and not well labelled 20% Access control docs in multiple places and not labelled 0% Admin Control information could not be found

20) Is the information clear and complete (%)

Answer: 0%
There are currently no admin access controls documented in the Qubit Finance documentation. However, the addition of a Governance section is mentioned in their development roadmap.
Guidance: All the contracts are immutable -- 100% OR
a) All contracts are clearly labelled as upgradeable (or not) -- 30% AND b) The type of ownership is clearly indicated (OnlyOwner / MultiSig / Defined Roles) -- 30% AND c) The capabilities for change in the contracts are described -- 30%

How to improve this score:

Create a document that covers the items described above. An example is enclosed.

21) Is the information in non-technical terms that pertain to the investments (%)

Answer: 0%
There are currently no admin access controls documented in the Qubit Finance documentation. However, the addition of a Governance section is mentioned in their development roadmap.
Guidance: 100% All the contracts are immutable 90% Description relates to investments safety and updates in clear, complete non-software l language 30% Description all in software specific language 0% No admin control information could not be found

How to improve this score:

Create a document that covers the items described above in plain language that investors can understand. An example is enclosed.

22) Is there Pause Control documentation including records of tests (%)

Answer: 0%
There is no evidence of a Pause Control or a similar function in the Qubit Finance documentation.
Guidance: 100% All the contracts are immutable or no pause control needed and this is explained OR 100% Pause control(s) are clearly documented and there is records of at least one test within 3 months 80% Pause control(s) explained clearly but no evidence of regular tests 40% Pause controls mentioned with no detail on capability or tests 0% Pause control not documented or explained

How to improve this score:

Create a document that covers the items described above in plain language that investors can understand. An example is enclosed.

Appendices

Author Details

The author of this review is Rex of DeFi Safety.
Email : [email protected] Twitter : @defisafety
I started with Ethereum just before the DAO and that was a wonderful education. It showed the importance of code quality. The second Parity hack also showed the importance of good process. Here my aviation background offers some value. Aerospace knows how to make reliable code using quality processes.
I was coaxed to go to EthDenver 2018 and there I started SecuEth.org with Bryant and Roman. We created guidelines on good processes for blockchain code development. We got EthFoundation funding to assist in their development.
Process Quality Reviews are an extension of the SecurEth guidelines that will further increase the quality processes in Solidity and Vyper development.
DeFiSafety is my full time gig and we are working on funding vehicles for a permanent staff.

Scoring Appendix

Executing Code Appendix

Code Used Appendix

Example Code Appendix

1
contract QubitLocker is IQubitLocker, WhitelistUpgradeable, ReentrancyGuardUpgradeable {
2
using SafeMath for uint;
3
using SafeToken for address;
4
5
/* ========== CONSTANTS ============= */
6
7
address public constant QBT = 0x17B7163cf1Dbd286E262ddc68b553D899B93f526;
8
9
uint public constant LOCK_UNIT_BASE = 7 days;
10
uint public constant LOCK_UNIT_MAX = 2 * 365 days;
11
12
/* ========== STATE VARIABLES ========== */
13
14
mapping(address => uint) public balances;
15
mapping(address => uint) public expires;
16
17
uint public override totalBalance;
18
19
uint private _lastTotalScore;
20
uint private _lastSlope;
21
uint private _lastTimestamp;
22
mapping(uint => uint) private _slopeChanges;
23
24
/* ========== INITIALIZER ========== */
25
26
function initialize() external initializer {
27
__WhitelistUpgradeable_init();
28
__ReentrancyGuard_init();
29
_lastTimestamp = block.timestamp;
30
}
31
32
/* ========== VIEWS ========== */
33
34
function balanceOf(address account) external view override returns (uint) {
35
return balances[account];
36
}
37
38
function expiryOf(address account) external view override returns (uint) {
39
return expires[account];
40
}
41
42
function availableOf(address account) external view override returns (uint) {
43
return expires[account] < block.timestamp ? balances[account] : 0;
44
}
45
46
function balanceExpiryOf(address account) external view override returns (uint balance, uint expiry) {
47
return (balances[account], expires[account]);
48
}
49
50
function totalScore() public view override returns (uint score, uint slope) {
51
score = _lastTotalScore;
52
slope = _lastSlope;
53
54
uint prevTimestamp = _lastTimestamp;
55
uint nextTimestamp = truncateExpiry(_lastTimestamp).add(LOCK_UNIT_BASE);
56
while (nextTimestamp < block.timestamp) {
57
uint deltaScore = nextTimestamp.sub(prevTimestamp).mul(slope);
58
score = score < deltaScore ? 0 : score.sub(deltaScore);
59
slope = slope.sub(_slopeChanges[nextTimestamp]);
60
61
prevTimestamp = nextTimestamp;
62
nextTimestamp = nextTimestamp.add(LOCK_UNIT_BASE);
63
}
64
65
uint deltaScore = block.timestamp > prevTimestamp ? block.timestamp.sub(prevTimestamp).mul(slope) : 0;
66
score = score > deltaScore ? score.sub(deltaScore) : 0;
67
}
68
69
/**
70
* @notice Calculate time-weighted balance of account
71
* @param account Account of which the balance will be calculated
72
*/
73
function scoreOf(address account) external view override returns (uint) {
74
if (expires[account] < block.timestamp) return 0;
75
return expires[account].sub(block.timestamp).mul(balances[account].div(LOCK_UNIT_MAX));
76
}
77
78
function truncateExpiry(uint time) public pure returns (uint) {
79
return time.div(LOCK_UNIT_BASE).mul(LOCK_UNIT_BASE);
80
}
81
82
/* ========== MUTATIVE FUNCTIONS ========== */
83
84
function deposit(uint amount, uint expiry) external override nonReentrant {
85
require(amount > 0, "QubitLocker: invalid amount");
86
87
expiry = balances[msg.sender] == 0 ? truncateExpiry(expiry) : expires[msg.sender];
88
require(block.timestamp < expiry && expiry <= block.timestamp + LOCK_UNIT_MAX, "QubitLocker: invalid expiry");
89
90
_slopeChanges[expiry] = _slopeChanges[expiry].add(amount.div(LOCK_UNIT_MAX));
91
_updateTotalScore(amount, expiry);
92
93
QBT.safeTransferFrom(msg.sender, address(this), amount);
94
totalBalance = totalBalance.add(amount);
95
96
balances[msg.sender] = balances[msg.sender].add(amount);
97
expires[msg.sender] = expiry;
98
}
99
100
function extendLock(uint nextExpiry) external override nonReentrant {
101
uint amount = balances[msg.sender];
102
require(amount > 0, "QubitLocker: zero balance");
103
104
uint prevExpiry = expires[msg.sender];
105
nextExpiry = truncateExpiry(nextExpiry);
106
require(
107
Math.max(prevExpiry, block.timestamp) < nextExpiry && nextExpiry <= block.timestamp + LOCK_UNIT_MAX,
108
"QubitLocker: invalid expiry time"
109
);
110
111
uint slopeChange = (_slopeChanges[prevExpiry] < amount.div(LOCK_UNIT_MAX))
112
? _slopeChanges[prevExpiry]
113
: amount.div(LOCK_UNIT_MAX);
114
_slopeChanges[prevExpiry] = _slopeChanges[prevExpiry].sub(slopeChange);
115
_slopeChanges[nextExpiry] = _slopeChanges[nextExpiry].add(slopeChange);
116
_updateTotalScoreExtendingLock(amount, prevExpiry, nextExpiry);
117
expires[msg.sender] = nextExpiry;
118
}
119
120
/**
121
* @notice Withdraw all tokens for `msg.sender`
122
* @dev Only possible if the lock has expired
123
*/
124
function withdraw() external override nonReentrant {
125
require(balances[msg.sender] > 0 && block.timestamp >= expires[msg.sender], "QubitLocker: invalid state");
126
_updateTotalScore(0, 0);
127
128
uint amount = balances[msg.sender];
129
totalBalance = totalBalance.sub(amount);
130
delete balances[msg.sender];
131
delete expires[msg.sender];
132
QBT.safeTransfer(msg.sender, amount);
133
}
134
135
function depositBehalf(
136
address account,
137
uint amount,
138
uint expiry
139
) external override onlyWhitelisted nonReentrant {
140
require(amount > 0, "QubitLocker: invalid amount");
141
142
expiry = balances[account] == 0 ? truncateExpiry(expiry) : expires[account];
143
require(block.timestamp < expiry && expiry <= block.timestamp + LOCK_UNIT_MAX, "QubitLocker: invalid expiry");
144
145
_slopeChanges[expiry] = _slopeChanges[expiry].add(amount.div(LOCK_UNIT_MAX));
146
_updateTotalScore(amount, expiry);
147
148
QBT.safeTransferFrom(msg.sender, address(this), amount);
149
totalBalance = totalBalance.add(amount);
150
151
balances[account] = balances[account].add(amount);
152
expires[account] = expiry;
153
}
154
155
function withdrawBehalf(address account) external override onlyWhitelisted nonReentrant {
156
require(balances[account] > 0 && block.timestamp >= expires[account], "QubitLocker: invalid state");
157
_updateTotalScore(0, 0);
158
159
uint amount = balances[account];
160
totalBalance = totalBalance.sub(amount);
161
delete balances[account];
162
delete expires[account];
163
QBT.safeTransfer(account, amount);
164
}
Copied!

SLOC Appendix

Solidity Contracts

Language
Files
Lines
Blanks
Comments
Code
Complexity
Solidity
17
3436
556
714
2166
292
Comments to Code: 714/2166 = 33%

Javascript Tests

Language
Files
Lines
Blanks
Comments
Code
Complexity
JavaScript
N/A
N/A
N/A
N/A
N/A
N/A
Tests to Code: N/A
Last modified 22d ago