P
P
PQ Reviews
Search…
0.7
Alpha Homora V2 Process Quality Review
Score: 26%

Overview

This is an Alpha Homora Process Quality Review completed on the 9th of December, 2021. It was performed using the Process Review process (version 0.7.3) and is documented here. The review was performed by Nick of DeFiSafety. Check out our Telegram.
The final score of the review is 26%, a FAIL. The breakdown of the scoring is in Scoring Appendix. For our purposes, a pass is 70%.

Summary of the Process

Very simply, the review looks for the following declarations from the developer's site. With these declarations, it is reasonable to trust the smart contracts.
  • Here are my smart contracts on the blockchain
  • Here is the documentation that explains what my smart contracts do
  • Here are the tests I ran to verify my smart contract
  • Here are the audit(s) performed on my code by third party experts
  • Here are the admin controls and strategies

Disclaimer

This report is for informational purposes only and does not constitute investment advice of any kind, nor does it constitute an offer to provide investment advisory or other services. Nothing in this report shall be considered a solicitation or offer to buy or sell any security, token, future, option or other financial instrument or to offer or provide any investment advice or service to any person in any jurisdiction. Nothing contained in this report constitutes investment advice or offers any opinion with respect to the suitability of any security, and the views expressed in this report should not be taken as advice to buy, sell or hold any security. The information in this report should not be relied upon for the purpose of investing. In preparing the information contained in this report, we have not taken into account the investment needs, objectives and financial circumstances of any particular investor. This information has no regard to the specific investment objectives, financial situation and particular needs of any specific recipient of this information and investments discussed may not be suitable for all investors.
Any views expressed in this report by us were prepared based upon the information available to us at the time such views were written. The views expressed within this report are limited to DeFiSafety and the author and do not reflect those of any additional or third party and are strictly based upon DeFiSafety, its authors, interpretations and evaluation of relevant data. Changed or additional information could cause such views to change. All information is subject to possible correction. Information may quickly become unreliable for various reasons, including changes in market conditions or economic circumstances.
This completed report is copyright (c) DeFiSafety 2021. Permission is given to copy in whole, retaining this copyright label.

Chain

This section indicates the blockchains used by this protocol. This report covers all of the blockchains upon which the protocol is deployed.
Chain: Ethereum, Binance Smart Chain, Avalanche
Guidance: Ethereum Binance Smart Chain Polygon Avalanche Terra Celo Arbitrum Solana

Code and Team

This section looks at the code deployed on the Mainnet that gets reviewed and its corresponding software repository. The document explaining these questions is here. This review will answer the following questions:
1) Are the executing code addresses readily available? (%) 2) Is the code actively being used? (%) 3) Is there a public software repository? (Y/N) 4) Is there a development history visible? (%) 5) Is the team public (not anonymous)? (Y/N)

1) Are the executing code addresses readily available? (%)

Answer: 0%
Contracts could not be found in either the docs or the GitHub. No audits specify the address of the contracts.
Guidance: 100% Clearly labelled and on website, docs or repo, quick to find 70% Clearly labelled and on website, docs or repo but takes a bit of looking 40% Addresses in mainnet.json, in discord or sub graph, etc 20% Address found but labeling not clear or easy to find 0% Executing addresses could not be found

How to improve this score:

Make the Ethereum addresses of the smart contract utilized by your application available on either your website or your GitHub (in the README for instance). Ensure the addresses is up to date. This is a very important question towards the final score.

2) Is the code actively being used? (%)

Answer: 0%
Activity could not be determined due to an inability to locate contract addresses.

Guidance:

100% More than 10 transactions a day 70% More than 10 transactions a week 40% More than 10 transactions a month 10% Less than 10 transactions a month 0% No activity

3) Is there a public software repository? (Y/N)

Answer: Yes
Is there a public software repository with the code at a minimum, but also normally test and scripts. Even if the repository was created just to hold the files and has just 1 transaction, it gets a "Yes". For teams with private repositories, this answer is "No".

4) Is there a development history visible? (%)

Answer: 100%
At 400 commits, Alpha Homora demonstrates a good commitment to strong documentation practises.
This metric checks if the software repository demonstrates a strong steady history. This is normally demonstrated by commits, branches and releases in a software repository. A healthy history demonstrates a history of more than a month (at a minimum).
Guidance: 100% Any one of 100+ commits, 10+branches 70% Any one of 70+ commits, 7+branches 50% Any one of 50+ commits, 5+branches 30% Any one of 30+ commits, 3+branches 0% Less than 2 branches or less than 30 commits

How to improve this score:

Continue to test and perform other verification activities after deployment, including routine maintenance updating to new releases of testing and deployment tools. A public development history indicates clearly to the public the level of continued investment and activity by the developers on the application. This gives a level of security and faith in the application.

5) Is the team public (not anonymous)? (Y/N)

Answer: Yes
The team is public.
For a "Yes" in this question, the real names of some team members must be public on the website or other documentation (LinkedIn, etc). If the team is anonymous, then this question is a "No".

Documentation

This section looks at the software documentation. The document explaining these questions is here.
Required questions are;
6) Is there a whitepaper? (Y/N) 7) Are the basic software functions documented? (Y/N) 8) Does the software function documentation fully (100%) cover the deployed contracts? (%) 9) Are there sufficiently detailed comments for all functions within the deployed contract code (%) 10) Is it possible to trace from software documentation to the implementation in code (%)

6) Is there a whitepaper? (Y/N)

Answer: Yes

7) Are the basic software functions documented? (Y/N)

Answer: No
No software functions are documented.

8) Does the software function documentation fully (100%) cover the deployed contracts? (%)

Answer: 0%
There is software function documentation.
Guidance:
100% All contracts and functions documented 80% Only the major functions documented 79-1% Estimate of the level of software documentation 0% No software documentation

How to improve this score:

This score can be improved by adding content to the software functions document such that it comprehensively covers the requirements. For guidance, refer to the SecurEth System Description Document. Using tools that aid traceability detection will help.

9) Are there sufficiently detailed comments for all functions within the deployed contract code (%)

Answer: 0%
Code examples are in the Appendix. As per the SLOC, there is 18% commenting to code (CtC).
The Comments to Code (CtC) ratio is the primary metric for this score.
Guidance: 100% CtC > 100 Useful comments consistently on all code 90-70% CtC > 70 Useful comment on most code 60-20% CtC > 20 Some useful commenting 0% CtC < 20 No useful commenting

How to improve this score

This score can improve by adding comments to the deployed code such that it comprehensively covers the code. For guidance, refer to the SecurEth Software Requirements.

10) Is it possible to trace from software documentation to the implementation in code (%)

Answer: 0%
There is no traceability from software documentation to code.
Guidance: 100% Clear explicit traceability between code and documentation at a requirement level for all code 60% Clear association between code and documents via non explicit traceability 40% Documentation lists all the functions and describes their functions 0% No connection between documentation and code

How to improve this score:

This score can improve by adding traceability from documentation to code such that it is clear where each outlined function is coded in the source code. For reference, check the SecurEth guidelines on traceability.

Testing

This section looks at the software testing available. It is explained in this document. This section answers the following questions;
11) Full test suite (Covers all the deployed code) (%) 12) Code coverage (Covers all the deployed lines of code, or explains misses) (%) 13) Scripts and instructions to run the tests (Y/N) 14) Report of the results (%) 15) Formal Verification test done (%) 16) Stress Testing environment (%)

11) Is there a Full test suite? (%)

Answer: 100%
Code examples are in the Appendix. As per the SLOC, there is 138% testing to code (TtC).
This score is guided by the Test to Code ratio (TtC). Generally a good test to code ratio is over 100%. However the reviewers best judgement is the final deciding factor.
Guidance: 100% TtC > 120% Both unit and system test visible 80% TtC > 80% Both unit and system test visible 40% TtC < 80% Some tests visible 0% No tests obvious

How to improve this score:

This score can improved by adding tests to fully cover the code. Document what is covered by traceability or test results in the software repository.

12) Code coverage (Covers all the deployed lines of code, or explains misses) (%)

Answer: 50%
No tests for code coverage were seen, but it's clear that this protocol has undergone testing.
Guidance: 100% Documented full coverage 99-51% Value of test coverage from documented results 50% No indication of code coverage but clearly there is a reasonably complete set of tests 30% Some tests evident but not complete 0% No test for coverage seen

How to improve this score:

This score can improved by adding tests that achieve full code coverage. A clear report and scripts in the software repository will guarantee a high score.

13) Scripts and instructions to run the tests (Y/N)

Answer: Yes
Test scripts were found.

How to improve this score:

Add the scripts to the repository and ensure they work. Ask an outsider to create the environment and run the tests. Improve the scripts and docs based on their feedback.

14) Report of the results (%)

Answer: 0%
No test report was found.
Guidance: 100% Detailed test report as described below 70% GitHub code coverage report visible 0% No test report evident

How to improve this score

Add a report with the results. The test scripts should generate the report or elements of it.

15) Formal Verification test done (%)

Answer: 0%
No formal verification has been undertaken.

16) Stress Testing environment (%)

Answer: 0%
No testnet deployment was documented.

Security

This section looks at the 3rd party software audits done. It is explained in this document. This section answers the following questions;
17) Did 3rd Party audits take place? (%) 18) Is the bounty value acceptably high?

17) Did 3rd Party audits take place? (%)

Answer: 0%
Despite three audits no listed contracts mean we cannot award points for them as per guidance.
Guidance: 100% Multiple Audits performed before deployment and results public and implemented or not required 90% Single audit performed before deployment and results public and implemented or not required 70% Audit(s) performed after deployment and no changes required. Audit report is public
50% Audit(s) performed after deployment and changes needed but not implemented 20% No audit performed 0% Audit Performed after deployment, existence is public, report is not public and no improvements deployed OR smart contract address' not found, (where question 1 is 0%)
Deduct 25% if code is in a private repo and no note from auditors that audit is applicable to deployed code

18) Is the bounty value acceptably high (%)

Answer: 90%
With a $750k active bounty, this bug bounty is sufficient.
Guidance:
100% Bounty is 10% TVL or at least $1M AND active program (see below) 90% Bounty is 5% TVL or at least 500k AND active program 80% Bounty is 5% TVL or at least 500k 70% Bounty is 100k or over AND active program 60% Bounty is 100k or over 50% Bounty is 50k or over AND active program 40% Bounty is 50k or over 20% Bug bounty program bounty is less than 50k 0% No bug bounty program offered
An active program means that a third party (such as Immunefi) is actively driving hackers to the site. An inactive program would be static mentions on the docs.

Access Controls

This section covers the documentation of special access controls for a DeFi protocol. The admin access controls are the contracts that allow updating contracts or coefficients in the protocol. Since these contracts can allow the protocol admins to "change the rules", complete disclosure of capabilities is vital for user's transparency. It is explained in this document. The questions this section asks are as follow;
19) Can a user clearly and quickly find the status of the admin controls? 20) Is the information clear and complete? 21) Is the information in non-technical terms that pertain to the investments? 22) Is there Pause Control documentation including records of tests?

19) Can a user clearly and quickly find the status of the access controls (%)

Answer: 0%
Admin Control information could not be found.
Guidance: 100% Clearly labelled and on website, docs or repo, quick to find 70% Clearly labelled and on website, docs or repo but takes a bit of looking 40% Access control docs in multiple places and not well labelled 20% Access control docs in multiple places and not labelled 0% Admin Control information could not be found

20) Is the information clear and complete (%)

Answer: 0%
Admin Control information could not be found.
Guidance: All the contracts are immutable -- 100% OR
a) All contracts are clearly labelled as upgradeable (or not) -- 30% AND b) The type of ownership is clearly indicated (OnlyOwner / MultiSig / Defined Roles) -- 30% AND c) The capabilities for change in the contracts are described -- 30%

How to improve this score:

Create a document that covers the items described above. An example is enclosed.

21) Is the information in non-technical terms that pertain to the investments (%)

Answer: 0%
Admin Control information could not be found.
Guidance: 100% All the contracts are immutable 90% Description relates to investments safety and updates in clear, complete non-software l language 30% Description all in software specific language 0% No admin control information could not be found

How to improve this score:

Create a document that covers the items described above in plain language that investors can understand. An example is enclosed.

22) Is there Pause Control documentation including records of tests (%)

Answer: 0%
Pause Control information could not be found
Guidance: 100% All the contracts are immutable or no pause control needed and this is explained OR 100% Pause control(s) are clearly documented and there is records of at least one test within 3 months 80% Pause control(s) explained clearly but no evidence of regular tests 40% Pause controls mentioned with no detail on capability or tests 0% Pause control not documented or explained

How to improve this score:

Create a document that covers the items described above in plain language that investors can understand. An example is enclosed.

Appendices

Author Details

The author of this review is Rex of DeFi Safety.
Email : [email protected] Twitter : @defisafety
I started with Ethereum just before the DAO and that was a wonderful education. It showed the importance of code quality. The second Parity hack also showed the importance of good process. Here my aviation background offers some value. Aerospace knows how to make reliable code using quality processes.
I was coaxed to go to EthDenver 2018 and there I started SecuEth.org with Bryant and Roman. We created guidelines on good processes for blockchain code development. We got EthFoundation funding to assist in their development.
Process Quality Reviews are an extension of the SecurEth guidelines that will further increase the quality processes in Solidity and Vyper development.
DeFiSafety is my full time gig and we are working on funding vehicles for a permanent staff.

Scoring Appendix

Executing Code Appendix

Contracts were not found.

Code Used Appendix

Contracts were not found.

Example Code Appendix

1
pragma solidity 0.6.12;
2
3
import 'OpenZeppelin/[email protected]/contracts/token/ERC20/IERC20.sol';
4
import 'OpenZeppelin/[email protected]/contracts/token/ERC20/SafeERC20.sol';
5
import 'OpenZeppelin/[email protected]/contracts/token/ERC1155/IERC1155.sol';
6
import 'OpenZeppelin/[email protected]/contracts/math/SafeMath.sol';
7
import 'OpenZeppelin/[email protected]/contracts/math/Math.sol';
8
9
import './Governable.sol';
10
import './utils/ERC1155NaiveReceiver.sol';
11
import '../interfaces/IBank.sol';
12
import '../interfaces/ICErc20.sol';
13
import '../interfaces/IOracle.sol';
14
15
library HomoraSafeMath {
16
using SafeMath for uint;
17
18
/// @dev Computes round-up division.
19
function ceilDiv(uint a, uint b) internal pure returns (uint) {
20
return a.add(b).sub(1).div(b);
21
}
22
}
23
24
contract HomoraCaster {
25
/// @dev Call to the target using the given data.
26
/// @param target The address target to call.
27
/// @param data The data used in the call.
28
function cast(address target, bytes calldata data) external payable {
29
(bool ok, bytes memory returndata) = target.call{value: msg.value}(data);
30
if (!ok) {
31
if (returndata.length > 0) {
32
// The easiest way to bubble the revert reason is using memory via assembly
33
// solhint-disable-next-line no-inline-assembly
34
assembly {
35
let returndata_size := mload(returndata)
36
revert(add(32, returndata), returndata_size)
37
}
38
} else {
39
revert('bad cast call');
40
}
41
}
42
}
43
}
44
45
contract HomoraBank is Governable, ERC1155NaiveReceiver, IBank {
46
using SafeMath for uint;
47
using HomoraSafeMath for uint;
48
using SafeERC20 for IERC20;
49
50
uint private constant _NOT_ENTERED = 1;
51
uint private constant _ENTERED = 2;
52
uint private constant _NO_ID = uint(-1);
53
address private constant _NO_ADDRESS = address(1);
54
55
struct Bank {
56
bool isListed; // Whether this market exists.
57
uint8 index; // Reverse look up index for this bank.
58
address cToken; // The CToken to draw liquidity from.
59
uint reserve; // The reserve portion allocated to Homora protocol.
60
uint totalDebt; // The last recorded total debt since last action.
61
uint totalShare; // The total debt share count across all open positions.
62
}
63
64
struct Position {
65
address owner; // The owner of this position.
66
address collToken; // The ERC1155 token used as collateral for this position.
67
uint collId; // The token id used as collateral.
68
uint collateralSize; // The size of collateral token for this position.
69
uint debtMap; // Bitmap of nonzero debt. i^th bit is set iff debt share of i^th bank is nonzero.
70
mapping(address => uint) debtShareOf; // The debt share for each token.
71
}
72
73
uint public _GENERAL_LOCK; // TEMPORARY: re-entrancy lock guard.
74
uint public _IN_EXEC_LOCK; // TEMPORARY: exec lock guard.
75
uint public override POSITION_ID; // TEMPORARY: position ID currently under execution.
76
address public override SPELL; // TEMPORARY: spell currently under execution.
77
78
address public caster; // The caster address for untrusted execution.
79
IOracle public oracle; // The oracle address for determining prices.
80
uint public feeBps; // The fee collected as protocol reserve in basis points from interest.
81
uint public override nextPositionId; // Next available position ID, starting from 1 (see initialize).
82
83
address[] public allBanks; // The list of all listed banks.
84
mapping(address => Bank) public banks; // Mapping from token to bank data.
85
mapping(address => bool) public cTokenInBank; // Mapping from cToken to its existence in bank.
86
mapping(uint => Position) public positions; // Mapping from position ID to position data.
87
88
bool public allowContractCalls; // The boolean status whether to allow call from contract (false = onlyEOA)
89
mapping(address => bool) public whitelistedTokens; // Mapping from token to whitelist status
90
mapping(address => bool) public whitelistedSpells; // Mapping from spell to whitelist status
91
mapping(address => bool) public whitelistedUsers; // Mapping from user to whitelist status
92
93
uint public bankStatus; // Each bit stores certain bank status, e.g. borrow allowed, repay allowed
94
95
/// @dev Ensure that the function is called from EOA when allowContractCalls is set to false and caller is not whitelisted
96
modifier onlyEOAEx() {
97
if (!allowContractCalls && !whitelistedUsers[msg.sender]) {
98
require(msg.sender == tx.origin, 'not eoa');
99
}
100
_;
101
}
102
103
/// @dev Reentrancy lock guard.
104
modifier lock() {
105
require(_GENERAL_LOCK == _NOT_ENTERED, 'general lock');
106
_GENERAL_LOCK = _ENTERED;
107
_;
108
_GENERAL_LOCK = _NOT_ENTERED;
109
}
110
111
/// @dev Ensure that the function is called from within the execution scope.
112
modifier inExec() {
113
require(POSITION_ID != _NO_ID, 'not within execution');
114
require(SPELL == msg.sender, 'not from spell');
115
require(_IN_EXEC_LOCK == _NOT_ENTERED, 'in exec lock');
116
_IN_EXEC_LOCK = _ENTERED;
117
_;
118
_IN_EXEC_LOCK = _NOT_ENTERED;
119
}
120
121
/// @dev Ensure that the interest rate of the given token is accrued.
122
modifier poke(address token) {
123
accrue(token);
124
_;
125
}
126
127
/// @dev Initialize the bank smart contract, using msg.sender as the first governor.
128
/// @param _oracle The oracle smart contract address.
129
/// @param _feeBps The fee collected to Homora bank.
130
function initialize(IOracle _oracle, uint _feeBps) external initializer {
131
__Governable__init();
132
_GENERAL_LOCK = _NOT_ENTERED;
133
_IN_EXEC_LOCK = _NOT_ENTERED;
134
POSITION_ID = _NO_ID;
135
SPELL = _NO_ADDRESS;
136
caster = address(new HomoraCaster());
137
oracle = _oracle;
138
require(address(_oracle) != address(0), 'bad oracle address');
139
feeBps = _feeBps;
140
nextPositionId = 1;
141
bankStatus = 3; // allow both borrow and repay
142
emit SetOracle(address(_oracle));
143
emit SetFeeBps(_feeBps);
144
}
145
146
/// @dev Return the current executor (the owner of the current position).
147
function EXECUTOR() external view override returns (address) {
148
uint positionId = POSITION_ID;
149
require(positionId != _NO_ID, 'not under execution');
150
return positions[positionId].owner;
151
}
152
153
/// @dev Set allowContractCalls
154
/// @param ok The status to set allowContractCalls to (false = onlyEOA)
155
function setAllowContractCalls(bool ok) external onlyGov {
156
allowContractCalls = ok;
157
}
158
159
/// @dev Set whitelist spell status
160
/// @param spells list of spells to change status
161
/// @param statuses list of statuses to change to
162
function setWhitelistSpells(address[] calldata spells, bool[] calldata statuses)
163
external
164
onlyGov
165
{
166
require(spells.length == statuses.length, 'spells & statuses length mismatched');
167
for (uint idx = 0; idx < spells.length; idx++) {
168
whitelistedSpells[spells[idx]] = statuses[idx];
169
}
170
}
171
172
/// @dev Set whitelist token status
173
/// @param tokens list of tokens to change status
174
/// @param statuses list of statuses to change to
175
function setWhitelistTokens(address[] calldata tokens, bool[] calldata statuses)
176
external
177
onlyGov
178
{
179
require(tokens.length == statuses.length, 'tokens & statuses length mismatched');
180
for (uint idx = 0; idx < tokens.length; idx++) {
181
if (statuses[idx]) {
182
// check oracle suppport
183
require(support(tokens[idx]), 'oracle not support token');
184
}
185
whitelistedTokens[tokens[idx]] = statuses[idx];
186
}
187
}
188
189
/// @dev Set whitelist user status
190
/// @param users list of users to change status
191
/// @param statuses list of statuses to change to
192
function setWhitelistUsers(address[] calldata users, bool[] calldata statuses) external onlyGov {
193
require(users.length == statuses.length, 'users & statuses length mismatched');
194
for (uint idx = 0; idx < users.length; idx++) {
195
whitelistedUsers[users[idx]] = statuses[idx];
196
}
197
}
198
199
/// @dev Check whether the oracle supports the token
200
/// @param token ERC-20 token to check for support
201
function support(address token) public view override returns (bool) {
202
return oracle.support(token);
203
}
204
205
/// @dev Set bank status
206
/// @param _bankStatus new bank status to change to
207
function setBankStatus(uint _bankStatus) external onlyGov {
208
bankStatus = _bankStatus;
209
}
210
211
/// @dev Bank borrow status allowed or not
212
/// @notice check last bit of bankStatus
213
function allowBorrowStatus() public view returns (bool) {
214
return (bankStatus & 0x01) > 0;
215
}
216
217
/// @dev Bank repay status allowed or not
218
/// @notice Check second-to-last bit of bankStatus
219
function allowRepayStatus() public view returns (bool) {
220
return (bankStatus & 0x02) > 0;
221
}
222
223
/// @dev Trigger interest accrual for the given bank.
224
/// @param token The underlying token to trigger the interest accrual.
225
function accrue(address token) public override {
226
Bank storage bank = banks[token];
227
require(bank.isListed, 'bank not exist');
228
uint totalDebt = bank.totalDebt;
229
uint debt = ICErc20(bank.cToken).borrowBalanceCurrent(address(this));
230
if (debt > totalDebt) {
231
uint fee = debt.sub(totalDebt).mul(feeBps).div(10000);
232
bank.totalDebt = debt;
233
bank.reserve = bank.reserve.add(doBorrow(token, fee));
234
} else if (totalDebt != debt) {
235
// We should never reach here because CREAMv2 does not support *repayBorrowBehalf*
236
// functionality. We set bank.totalDebt = debt nonetheless to ensure consistency. But do
237
// note that if *repayBorrowBehalf* exists, an attacker can maliciously deflate debt
238
// share value and potentially make this contract stop working due to math overflow.
239
bank.totalDebt = debt;
240
}
241
}
242
243
/// @dev Convenient function to trigger interest accrual for a list of banks.
244
/// @param tokens The list of banks to trigger interest accrual.
245
function accrueAll(address[] memory tokens) external {
246
for (uint idx = 0; idx < tokens.length; idx++) {
247
accrue(tokens[idx]);
248
}
249
}
250
251
/// @dev Return the borrow balance for given position and token without triggering interest accrual.
252
/// @param positionId The position to query for borrow balance.
253
/// @param token The token to query for borrow balance.
254
function borrowBalanceStored(uint positionId, address token) public view override returns (uint) {
255
uint totalDebt = banks[token].totalDebt;
256
uint totalShare = banks[token].totalShare;
257
uint share = positions[positionId].debtShareOf[token];
258
if (share == 0 || totalDebt == 0) {
259
return 0;
260
} else {
261
return share.mul(totalDebt).ceilDiv(totalShare);
262
}
263
}
264
265
/// @dev Trigger interest accrual and return the current borrow balance.
266
/// @param positionId The position to query for borrow balance.
267
/// @param token The token to query for borrow balance.
268
function borrowBalanceCurrent(uint positionId, address token) external override returns (uint) {
269
accrue(token);
270
return borrowBalanceStored(positionId, token);
271
}
272
273
/// @dev Return bank information for the given token.
274
/// @param token The token address to query for bank information.
275
function getBankInfo(address token)
276
external
277
view
278
override
279
returns (
280
bool isListed,
281
address cToken,
282
uint reserve,
283
uint totalDebt,
284
uint totalShare
285
)
286
{
287
Bank storage bank = banks[token];
288
return (bank.isListed, bank.cToken, bank.reserve, bank.totalDebt, bank.totalShare);
289
}
290
291
/// @dev Return position information for the given position id.
292
/// @param positionId The position id to query for position information.
293
function getPositionInfo(uint positionId)
294
public
295
view
296
override
297
returns (
298
address owner,
299
address collToken,
300
uint collId,
301
uint collateralSize
302
)
303
{
304
Position storage pos = positions[positionId];
305
return (pos.owner, pos.collToken, pos.collId, pos.collateralSize);
306
}
Copied!

SLOC Appendix

Solidity Contracts

Language
Files
Lines
Blanks
Comments
Code
Complexity
Solidity
4
886
92
123
671
87
Comments to Code 123/671 = 18%

Javascript Tests

Language
Files
Lines
Blanks
Comments
Code
Complexity
JavaScript
15
1304
273
106
925
13
Tests to Code 925/671 = 138%
Last modified 1mo ago